Issues found by hphp static analysis #4444
Conversation
|
@rlerdorf Thanks for doing this! Quick question: is this against current master, or a specific tag? |
- Object being instantiated has no defined constructor in the inheritance tree.
- Cannot have a required argument following an optional argument.
- call to getConsoleUsage() was passing an argument the method did not accept or use.
- Call to _buildFolderTree() was passing an argument the method did not accept or use.
- Call to injectNotFoundReason() was passing an argument not accepted or used by the method.
- Calls to get() were passing a third, unused argument; removed.
- Missing sprintf()
- call to normalizeLibOptionKey() uses pass-by-reference, and has no return value. - Fixed code to operate on that assumption.
- write() appends directly to $pickle property, and does not have a return value. - Broke statements that appended write() operations into multiple statements.
- normalizeLibOptionKey() uses pass-by-reference, but statement was assuming a return value. - fixed method to use pass-by-reference
|
@rlerdorf I've patched all but Would having an explicit |
|
There are lots of false positives. I wouldn't change any code just to make the analyzer happy. What you probably should do is compile hhvm yourself and write a little filter script that is specific to ZF that filters out the AbstractRestfulController calls and the other false positives and run it occasionally. That is what I do for my stuff. |
|
Oh, and to answer your question, this was against master, but you probably figured that out. |
@rlerdorf Have you started work on one yet? If so, would you be willing to share it with me? The stuff it found was fantastic. :) |
|
A filter specific for ZF you mean? No, I just manually eyeballed it and removed the obvious false positives before sending you the results. |
|
@rlerdorf Okay, then I'll start looking into it myself. Thanks a ton for sending the feedback! |
ghost
assigned 
- Call to _buildFolderTree() was passing an argument the method did not accept or use.
- Calls to get() were passing a third, unused argument; removed.
- write() appends directly to $pickle property, and does not have a return value. - Broke statements that appended write() operations into multiple statements.
- call to normalizeLibOptionKey() uses pass-by-reference, and has no return value. - Fixed code to operate on that assumption.
- normalizeLibOptionKey() uses pass-by-reference, but statement was assuming a return value. - fixed method to use pass-by-reference
- Object being instantiated has no defined constructor in the inheritance tree.
I think I weeded out most of the false positives, but there may be a few still in there. For the TooManyArgument error it doesn't know about func_get_args(), so that is the most common false positive.